Skip to content
Snippets Groups Projects

avoid empty blocks when hiding ads

Merged dakkar requested to merge feature/avoid-empty-blocks-when-hiding-ads into develop

What does this MR do?

2024.10 or 2024.11 added a <div> around <MkAd>, but while MkAd checks if ads should be shown, and generates an empty <div> if not, the wrapper div was always shown.

This commit takes the same logic from MkAd and applies it to the wrapper as well.

thanks to @puppygirlhornypost for noticing

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this merge request

Merge request reports

Merge request pipeline #2164 passed

Merge request pipeline passed for e9e2a5dd

Merged by dakkardakkar 1 week ago (Dec 18, 2024 5:06pm UTC)

Merge details

  • Changes merged into with 12ef2b13.
  • Deleted the source branch.

Pipeline #2169 passed

Pipeline passed for 12ef2b13 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading