Skip to content
Snippets Groups Projects

use the whole hostname to check remote links - fixes #866

Merged dakkar requested to merge feature/866-external-url-warning-fixes into develop

What does this MR do?

the warning dialog's "trust this domain" toggle saves the whole hostname, so this code needs to use the whole hostname

otherwise trusting a www.example.com will never work, because we'd be checking example.com against it, and fail

while I was there, I also made the trustedLinkUrlPatterns correctly match sub-domains: previously, trusting ple.com would trust example.com

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this merge request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading