when creating a note as a side-effect, make it silent - fixes #986

What does this MR do?

What the title says.

I haven't really tested this, because my hacky way of running two instances (one on localhost:3000 and one on localhost:4000) stopped working. But it compiles, passes tests (but I don't think they cover this code path), and the linter/typecheck doesn't complain.

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

• I agree to follow this project's Contribution Guidelines
• I have made sure to test this merge request

added bugbackend label

requested review from @CenTdemeern1, @fEmber, and @Marie

approved this merge request

How would I see if this is working?

my test plan was:

• set up two instances, A and B
• set up one account on each, @a@A and @b@B
• create a note 1 in @a@A
• create a note 2 in @b@B
• follow @a@A from @b@B
• edit the note 1 in @a@A

expected result with this patch:

• instance B receives the Update for note 1
• instance B creates the note 1
• instance B does not inject the note 1 in (redis) timelines, but if you force a database search, note 1 should appear older than note 2
• the note 1 is visible in @a@A profile on instance B

expected result without this patch:

• instance B receives the Update for note 1
• instance B creates the note 1
• instance B injects the note 1 in timelines, and it appears younger than note 2
• the note 1 is visible in @a@A profile on instance B

finally fixed my setup to properly test this.

showing the effect without this patch:

the edited note shows up out of order

with this patch, the edited note does not show up immediately on the timeline (correctly), but on reload:

added 78 commits

• 12674a3f...92382b2e - 77 commits from branch develop
• ece57345 - when creating a note as a side-effect, make it silent - fixes #986

Compare with previous version