Make confirm follow prompt not show up when cancelling a follow request

What does this MR do?

The always show confirm follow prompt setting is on by default and cause MK decided to check for that first it will always get triggered when trying to cancel a follow request before even hitting the actual code that was meant to cancel the request.

This fix simply just adds a check making sure that the hasPendingFollowRequestFromYou value is false before prompting it.

Fixes #822 (closed)

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

• I agree to follow this project's Contribution Guidelines
• I have made sure to test this merge request

added bugfrontend label

requested review from @fEmber and @dakkar

changed the description

the button has 6 states, and its behaviour is different in each state:

1. waiting (while doing an API request), no behaviour
2. hasPendingFollowRequestFromYou && user.isLocked, clicking cancels the request
3. hasPendingFollowRequestFromYou && !user.isLocked, clicking cancel the request
4. isFollowing, clicking un-follows
5. !isFollowing && user.isLocked, clicking sends follow request
6. !isFollowing && !user.isLocked, clicking sends follow request

the current develop asks "do you want to follow?" in cases 2&3, which I agree is wrong

this patch removes the confirmation in those two cases. I feel that, instead, it should ask "do you want to cancel your follow request?"

added 1 commit

• 91e15faf - upd: confirm dialog for undoing follow request

Compare with previous version

added 1 commit

• add1c717 - chore: lint

Compare with previous version

I hate that this is the "correct" way of writing this code, to minimise future merge conflicts ☹️

approved this merge request

enabled an automatic merge when all merge checks for add1c717 pass

approved this merge request

merged

mentioned in commit aa169129