Skip to content
Snippets Groups Projects

fix notification dot

Merged dakkar requested to merge fix-notification-dot into develop

What does this MR do?

fix notification dot

  1. the crossOrigin='anonymous' tells the browser to actually honour CORS on the image

  2. the dot is now always 1/5 of the icon, even for large icons

  3. we use toBlob instead of toDataURL because https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/toDataURL says so

  4. the test now blinks the dot, so it tests the actual code

  5. if there's a problem during the test, we log the error, so people can tell it to us

Thanks to Ares on Discord for reporting the problems.

Contribution Guidelines

By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this merge request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading