Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
Sharkey-thenautilus
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
dakkar
Sharkey-thenautilus
Commits
1107a177
Commit
1107a177
authored
1 year ago
by
dakkar
Browse files
Options
Downloads
Patches
Plain Diff
notes on how to do upstream merges
parent
340a57d2
Branches
deck-nav
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
CONTRIBUTING.md
+25
-0
25 additions, 0 deletions
CONTRIBUTING.md
with
25 additions
and
0 deletions
CONTRIBUTING.md
+
25
−
0
View file @
1107a177
...
...
@@ -446,3 +446,28 @@ marginはそのコンポーネントを使う側が設定する
### indexというファイル名を使うな
ESMではディレクトリインポートは廃止されているのと、ディレクトリインポートせずともファイル名が index だと何故か一部のライブラリ?でディレクトリインポートだと見做されてエラーになる
## Merging from Misskey into Sharkey
Make sure you have both remotes in the same clone (
`git remote add misskey
https://github.com/misskey-dev/misskey.git`
), then:
git remote update
git checkout develop # this is Sharkey's develop
git checkout -m merge/$(date +%Y-%m-%d) # or whatever
git merge --no-ff misskey/develop
fix conflicts and
*commit*
!
*after that commit*
, do all the extra work, on the same branch:
*
copy all changes:
*
from
`NoteCreateService`
to
`NoteEditService`
*
from
`ApNoteService.createNote`
to
`ApNoteService.updateNote`
*
from
`endoints/notes/create.ts`
to
`endoints/notes/edit.ts`
*
from
`MkNote*`
to
`SkNote*`
(if sensible)
*
run tests
`pnpm test`
and fix as much as you can
*
run lint
`pnpm --filter=backend lint`
+
`pnpm --filter=frontend
eslint`
and fix as much as you can
Then push and open a Merge Request.
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment