perf(backend): reduce needless populateMyReaction calls

packages/backend/src/core/entities/NoteEntityService.ts

@@ -357,7 +357,7 @@ export class NoteEntityService implements OnModuleInit {
 
 				poll: note.hasPoll ? this.populatePoll(note, meId) : undefined,
 
-				...(meId ? {
+				...(meId && Object.keys(note.reactions).length > 0 ? {
 					myReaction: this.populateMyReaction(note.id, meId, options?._hint_),
 				} : {}),
 			} : {}),

packages/backend/src/server/api/stream/channels/channel.ts

@@ -46,8 +46,10 @@ class ChannelChannel extends Channel {
 		if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
 
 		if (this.user && note.renoteId && !note.text) {
-			const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
-			note.renote!.myReaction = myRenoteReaction;
+			if (note.renote && Object.keys(note.renote.reactions).length > 0) {
+				const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
+				note.renote!.myReaction = myRenoteReaction;
+			}
 		}
 
 		this.connection.cacheNote(note);

packages/backend/src/server/api/stream/channels/global-timeline.ts

@@ -72,8 +72,10 @@ class GlobalTimelineChannel extends Channel {
 		if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
 
 		if (this.user && note.renoteId && !note.text) {
-			const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
-			note.renote!.myReaction = myRenoteReaction;
+			if (note.renote && Object.keys(note.renote.reactions).length > 0) {
+				const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
+				note.renote!.myReaction = myRenoteReaction;
+			}
 		}
 
 		this.connection.cacheNote(note);

packages/backend/src/server/api/stream/channels/hashtag.ts

@@ -51,8 +51,10 @@ class HashtagChannel extends Channel {
 		if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
 
 		if (this.user && note.renoteId && !note.text) {
-			const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
-			note.renote!.myReaction = myRenoteReaction;
+			if (note.renote && Object.keys(note.renote.reactions).length > 0) {
+				const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
+				note.renote!.myReaction = myRenoteReaction;
+			}
 		}
 
 		this.connection.cacheNote(note);

packages/backend/src/server/api/stream/channels/home-timeline.ts

@@ -74,8 +74,10 @@ class HomeTimelineChannel extends Channel {
 		if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
 
 		if (this.user && note.renoteId && !note.text) {
-			const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
-			note.renote!.myReaction = myRenoteReaction;
+			if (note.renote && Object.keys(note.renote.reactions).length > 0) {
+				const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
+				note.renote!.myReaction = myRenoteReaction;
+			}
 		}
 
 		this.connection.cacheNote(note);

packages/backend/src/server/api/stream/channels/hybrid-timeline.ts

@@ -88,8 +88,10 @@ class HybridTimelineChannel extends Channel {
 		if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
 
 		if (this.user && note.renoteId && !note.text) {
-			const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
-			note.renote!.myReaction = myRenoteReaction;
+			if (note.renote && Object.keys(note.renote.reactions).length > 0) {
+				const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
+				note.renote!.myReaction = myRenoteReaction;
+			}
 		}
 
 		this.connection.cacheNote(note);

packages/backend/src/server/api/stream/channels/local-timeline.ts

@@ -71,8 +71,10 @@ class LocalTimelineChannel extends Channel {
 		if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
 
 		if (this.user && note.renoteId && !note.text) {
-			const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
-			note.renote!.myReaction = myRenoteReaction;
+			if (note.renote && Object.keys(note.renote.reactions).length > 0) {
+				const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
+				note.renote!.myReaction = myRenoteReaction;
+			}
 		}
 
 		this.connection.cacheNote(note);

packages/backend/src/server/api/stream/channels/user-list.ts

@@ -103,8 +103,10 @@ class UserListChannel extends Channel {
 		if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
 
 		if (this.user && note.renoteId && !note.text) {
-			const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
-			note.renote!.myReaction = myRenoteReaction;
+			if (note.renote && Object.keys(note.renote.reactions).length > 0) {
+				const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
+				note.renote!.myReaction = myRenoteReaction;
+			}
 		}
 
 		this.connection.cacheNote(note);