deleting a role can break notifications
(reported to @Amelia)
- create a role
- assign it to a user
- the user gets a notification about it
- delete the role
- the user's notifications are now broken
while we're there, we could check that all notifications behave sensibly when the object they referenece can't be fetched (I think the notification should not be displayed in that case)
Designs
- Show closed items
Link issues together to show that they're related or that one is blocking others.
Learn more.
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- dakkar added bugfrontend label
added bugfrontend label
Collapse replies - Please register or sign in to reply
Confirmed on v2024.8.2
Easily reproducible by:
- making a role
- adding a user to it
- deleting said role
Logs:
web-1 | ERR * [api] Internal error occurred in i/notifications-grouped: Could not find any entity of type "MiRole" matching: { web-1 | "id": "9zjah6x4p7wr029k" web-1 | } { web-1 | ep: 'i/notifications-grouped', web-1 | ps: { web-1 | excludeTypes: [], web-1 | limit: 20, web-1 | allowPartial: true, web-1 | i: '1nGflySMHZS0aP6y', web-1 | markAsRead: true web-1 | }, web-1 | e: { web-1 | message: 'Could not find any entity of type "MiRole" matching: {\n' + web-1 | ' "id": "9zjah6x4p7wr029k"\n' + web-1 | '}', web-1 | code: 'EntityNotFoundError', web-1 | stack: 'EntityNotFoundError: Could not find any entity of type "MiRole" matching: {\n' + web-1 | ' "id": "9zjah6x4p7wr029k"\n' + web-1 | '}\n' + web-1 | ' at /sharkey/node_modules/.pnpm/typeorm@0.3.20_ioredis@5.4.1_pg@8.12.0/node_modules/typeorm/entity-manager/EntityManager.js:664:39\n' + web-1 | ' at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n' + web-1 | ' at async RoleEntityService.pack (file:///sharkey/packages/backend/built/core/entities/RoleEntityService.js:35:54)\n' + web-1 | ' at async #packInternal (file:///sharkey/packages/backend/built/core/entities/NotificationEntityService.js:124:34)\n' + web-1 | ' at async NotificationEntityService.pack (file:///sharkey/packages/backend/built/core/entities/NotificationEntityService.js:223:16)\n' + web-1 | ' at async Promise.all (index 1)\n' + web-1 | ' at async #packManyInternal (file:///sharkey/packages/backend/built/core/entities/NotificationEntityService.js:219:17)\n' + web-1 | ' at async NotificationEntityService.packGroupedMany (file:///sharkey/packages/backend/built/core/entities/NotificationEntityService.js:229:16)\n' + web-1 | ' at async file:///sharkey/packages/backend/built/server/api/endpoints/i/notifications-grouped.js:197:20\n' + web-1 | ' at async ApiCallService.call (file:///sharkey/packages/backend/built/server/api/ApiCallService.js:382:20)', web-1 | id: 'a6881b73-ffca-4d21-9b62-c78bdd4b9abc' web-1 | } web-1 | }
now I gotta figure out how to get my notifications working again- JeDaYoshi mentioned in merge request !816 (merged)
mentioned in merge request !816 (merged)
- Hazelnoot closed with merge request !816 (merged)
closed with merge request !816 (merged)