Skip to content
Snippets Groups Projects

Fix notifications breaking due to deleted role being assigned

Merged JeDaYoshi requested to merge JeDaYoshi/Sharkey:fix-roleassign-notification into develop

What does this MR do?

Notifications currently break if you assign a role to a user (which notifies them), and then said role is deleted.

This case scenario is supposed to be handled already. However, this fix is not working, as this.roleEntityService.pack(notification.roleId) is throwing EntityNotFoundError, which is not handled.

Fixes #630 (closed)

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this merge request
Edited by JeDaYoshi

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading