Add replies collections to objects

What feature would you like implemented?

I'd like to have replies collections added to sharkey: objects should have a replies field, pointing to a collection of object ids, containing all replies to a specific post.

An example of this could be this post: you can explore its AP representation using a tool from my instance. You can see mastodon offers a replies collection in each object (masto does it a bit weirdly tho: the first collection page is empty but has a next? then there are all "replies from others"? i think it would be better to have them all together sorted chronologically but whatever mastodon :p )

Why should we add this feature?

This improves federation: other instances can pick up the thread context and reply accordingly. While not much software fetches replies collections, Mastodon and GoToSocial already offer these collections and they are super useful. Right now for me *key (and *oma) "break" threads: in my software replies between mastodon users get fetched properly, but as soon as someone from *key (or *oma) replies, they don't expose replies and so to keep on reading it's necessary to view on remote instance and copy-paste urls of replies manually.

Contribution Guidelines

By submitting this issue, you agree to follow our Contribution Guidelines

• I agree to follow this project's Contribution Guidelines
• I have searched the issue tracker for similar requests, and this is not a duplicate.

---

I'd like to help implementing this. I tried searching sharkey source a bit to open a PR together with this issue, but I'm struggling making sense of the codebase. Iceshrimp has some AP views, but sharkey got rid of them? I'm not sure where AP routes are, and how to add new ones. Can I ask for some directions on this? I'd gladly implement such feature and PR it in myself, but I'm quite lost (:

marked this issue as related to #249

marked this issue as related to #266

marked this issue as related to #205

marked this issue as related to #738 (closed)

thank you for volunteering!

the differences you saw between Iceshrimp and Sharkey are due to a rewrite in Misskey: Iceshrimp forked Misskey v12, Sharkey follows latest Misskey, which got a lot of rewrites on version 13

The place to add the replies field would be in ApRenderService.renderNote

The place to add the routing to provide the contents of the replies collection would be in ActivityPubServerService, with code probably very similar to how outbox is handled

added enhancement federation labels

This should be relatively straightforward to implement by using our outbox logic as a reference. I'll take a stab at it and see what I can come up with.

assigned to @fEmber

mentioned in merge request !918 (merged)

mentioned in commit 9fa3be82

closed with merge request !918 (merged)