Skip to content
Snippets Groups Projects

don't send real-time updates of replies to blocked users #457 #573

Merged dakkar requested to merge feature/457-real-time-update-honour-blocks into develop
All threads resolved!

What does this PR do?

As noted in real-time updates of replies may not honour blo... (#457 - closed), real time updates of replies in a note's detailed view included notes from users who blocked the currently logged-in user. This is undesirable: if I block someone, I don't want them to see any of me notes, even when I'm talking in their replies (timelines and notifications mostly already work this way).

With this change, we globally stop sending information about such replies to the frontend. Testing this is a bit annoying because lots of stuff is cached, so after blocking/unblocking we'd have to wait a bit before the change is effective.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading