What does this PR do?
As noted in real-time updates of replies may not honour blo... (#457 - closed), real time updates of replies in a note's detailed view included notes from users who blocked the currently logged-in user. This is undesirable: if I block someone, I don't want them to see any of me notes, even when I'm talking in their replies (timelines and notifications mostly already work this way).
With this change, we globally stop sending information about such replies to the frontend. Testing this is a bit annoying because lots of stuff is cached, so after blocking/unblocking we'd have to wait a bit before the change is effective.
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Merge request reports
Activity
- Resolved by dakkar
Honestly, I do not think this behaviour should be changed. I want to see the user's reply, regardless if the parent post is blocked or not. If one user posts one comment, and doesn't post in the rest of the thread, a user would not be able to see the rest of that thread. A better solution would be to just replace the post from the user who has blocked the client with a generic "post from a user who has blocked you" message.
While we're at it, why not make it more explicit that a user has blocked you?
added enhancement label
mentioned in commit 712af44d