Skip to content
Snippets Groups Projects

thunk the min/max promises

Merged dakkar requested to merge feature/maybe-better-ratelimit-promises into develop
All threads resolved!

What does this PR do?

@fEmber noticed that (in some cases) NodeJS logged a myriad of "lost" rate-limiter promises.

Apparently, if we create promises and don't use them, NodeJS gets a bit annoyed.

This minimal change should help: by changing the min / max variables from promises to functions that return promises (and changing the name, because min * max are built-in functions and would be called instead of ours), the promises only get created when needed.

I have tested this, but please re-test it!

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • dakkar added 1 commit

    added 1 commit

    • 17b6c1b3 - tell the linter to shut up, this time

    Compare with previous version

  • dakkar resolved all threads

    resolved all threads

  • Author Developer

    also @Latte_macchiato is testing this on plasmatrap

  • Works perfectly for me :)

  • Marie approved this merge request

    approved this merge request

  • Hazelnoot approved this merge request

    approved this merge request

  • dakkar mentioned in commit 9cf40ef4

    mentioned in commit 9cf40ef4

  • merged

  • Please register or sign in to reply
    Loading