Skip to content

thunk the min/max promises

dakkar requested to merge feature/maybe-better-ratelimit-promises into develop

What does this PR do?

@fEmber noticed that (in some cases) NodeJS logged a myriad of "lost" rate-limiter promises.

Apparently, if we create promises and don't use them, NodeJS gets a bit annoyed.

This minimal change should help: by changing the min / max variables from promises to functions that return promises (and changing the name, because min * max are built-in functions and would be called instead of ours), the promises only get created when needed.

I have tested this, but please re-test it!

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports