Draft: Separate Sharkey strings from Misskey (#624)
What does this PR do? (Please give us a brief description of what this PR does.)
separates all sharkey strings on sharkey-locales
and makes our locales
synced to misskey's. this allows us to have our own translation workflow, which helps sharkey be translated to other languages and also our locales don't get wiped by theirs whenever they update something : )
then, we merge them on build time (our translations overwrite theirs). as simple as possible
considerations:
- translations fallback in this order: Sharkey L10N -> Misskey L10N -> Sharkey English -> Misskey English. i prefer if it's in the user's native language over being in parity with sharkey.
- had to remove the sharkey-only changes that were made through prs because i'd have to manually check each one and it would be super hellish
- we probably want to setup a crowdin, have a cool workflow that copies misskey's for merging locales before merging this lol
- this is as seamless as possible as we don't have to change anything on our side if upstream adds new features
todo:
-
diff en-US and rewrite changes on sharkey-locales
-
revert locales
to upstream -
merge sharkey-locales
andlocales
on build -
setup localization platform -
update ui to show users where to contribute (placeholder link) -
update contributing.md
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Merge request reports
Activity
added 1 commit
- 672c4f74 - inform users about sharkey specific localization
- Resolved by dakkar
very nice!
we'll have to check that the resulting translations are close enough to our current ones (I'll try to do that today), but I agree with your decisions
@Marie opinions on crowdin vs weblate? I remember we tried weblate at one point, and dropped it because it quoted translate strings differently (which made the input files uglier), but if we have separate files for our own translations, that problem can be ignored…
added 1 commit
- 96d1d16a - reintroduce sharkey changes from other languages
- Resolved by piuvas silly
added enhancement label
- Resolved by dakkar
I have compared the translations generated by this branch, against the translations on misskey 2024.9.0, and I'm pretty sure that the differences are correct ("boost" instead of "renote", "sharkey" instead of "misskey", plus of course all the sharkey-specific strings)
I am a bit unsure how to merge this, because it will conflict with the 2024.9.0 merge, whichever way we do it… I'll play around a bit
mentioned in merge request !672 (merged)
mentioned in merge request !675 (merged)