try to avoid `insert` races in `FederatedInstanceService`
All threads resolved!
All threads resolved!
What does this PR do?
Despite the cache, different processes can race to insert a row for the same remote host.
This is particularly apparent in our unit tests, with test/unit/activitypub.ts
randomly failing.
This is a (somewhat clumsy) attempt at working around that race: trap the "duplicate key value" error, and fetch the record.
Tests pass, with or without values in the cache.
PLEASE DOUBLE CHECK MY LOGIC!
Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines
-
I agree to follow this project's Contribution Guidelines -
I have made sure to test this pull request
Merge request reports
Activity
Filter activity
added 1 commit
- 06bd29f2 - try to avoid `insert` races in `FederatedInstanceService`
- Resolved by dakkar
- Resolved by dakkar
added bugbackend label
mentioned in commit 45974a53
Please register or sign in to reply