Skip to content
Snippets Groups Projects

ignore stale `users/show` responses - fixes #741

Merged dakkar requested to merge feature/741-safer-login-checks into develop

What does this PR do?

Simplest fix: if a response comes in that does not match the current username, ignore it. Since the username changed, another request has been sent already, and the response will arrive at some point.

The "in case of error" code is a bit annoying because misskeyApi doesn't pass us any detail apart from the error code, so we now close over the username we requested, and compare against that.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Merge request pipeline #1473 passed

Merge request pipeline passed for bf6ca8ef

Approved by

Merged by HazelnootHazelnoot 5 months ago (Oct 12, 2024 5:57pm UTC)

Merge details

  • Changes merged into develop with 669e5c6c.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #1475 failed

Pipeline failed for 669e5c6c on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading