Skip to content
Snippets Groups Projects

ignore stale `users/show` responses - fixes #741

Merged ignore stale `users/show` responses - fixes #741
feature/741-safer-login-checks into develop
Merged dakkar requested to merge feature/741-safer-login-checks into develop
  1. Oct 12, 2024
    • dakkar's avatar
      also ignore stale *failed* responses - #741 · bf6ca8ef
      dakkar authored 
      since `misskeyApi` doesn't pass us the request, we close over a copy
of the username we requested, to make sure it still matches the
current username value
      bf6ca8ef
    • dakkar's avatar
      ignore stale `users/show` responses - fixes #741 · 5af38db7
      dakkar authored 
      * person starts typing "abcd"
* request for user "abcd" is sent to server
* person continues typing "ef"
* request for user "abcdef" is sent to server
* response for user "abcdef" arrives, icon for user "abcdef" is shown
* response for user "abcd" arrives, icon for user "abcd" was shown –
  with this commit, this response is ignored instead

This is not just "showing the wrong avatar", btw: `MkSignin` uses the
`user` variable to decide whether to use 2FA, so having the wrong data
in user can make a login attempt fail.
      5af38db7