Skip to content
Snippets Groups Projects

Optimizations to InternalStorageService (resolves #753)

Merged Hazelnoot requested to merge fEmber/Sharkey:hazelnoot/753-async-file-io into develop

What does this PR do?

Small optimizations to the file IO in InternalStorageService:

  • Use asynchronous IO for all functions.
  • Pre-create the files directory to avoid excess calls to mkdir.

Contribution Guidelines By submitting this merge request, you agree to follow our Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
  • I have made sure to test this pull request

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • dakkar
  • Hazelnoot added 271 commits

    added 271 commits

    • 5b00583d...ba17776b - 269 commits from branch TransFem-org:develop
    • 2deb6448 - use async IO for InternalStorageService
    • b1d9314d - pre-create the `files` directory to reduce IO operations

    Compare with previous version

  • Hazelnoot added 2 commits

    added 2 commits

    • 7aee3c16 - fix comment typo in InternalStorageService.ts
    • fcd2c93a - ensure that "thumbnail stored" / "web stored" messages only appear after success

    Compare with previous version

  • Hazelnoot resolved all threads

    resolved all threads

  • dakkar approved this merge request

    approved this merge request

  • Marie approved this merge request

    approved this merge request

  • merged

  • dakkar mentioned in commit 4ccc0c4b

    mentioned in commit 4ccc0c4b

  • Please register or sign in to reply
    Loading